Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #183

Merged
merged 3 commits into from
May 10, 2024
Merged

Fix tests #183

merged 3 commits into from
May 10, 2024

Conversation

martinghunt
Copy link
Member

@martinghunt martinghunt commented May 9, 2024 •
edited
Loading

  • Tests are failing on GitHub actions. Change everything from classes and setup/teardown to using pytest.fixtures. This should fix it, but will find out on creating this PR
  • Make sure all tests are discoverable with pytest (some were not and were never running)
  • Fix a bug in probe generation where probes with context variants could have mismatching ref and alt probes. The probe sequences were correct, but not in the same order between ref and alt probes. Reinstated the test that checked these probes, since it was not running
  • Ran black on all changed files
  • Looks like more changes than it really is: moving the tests out of classes made the indentation one level less, plus running black means diff looks big

@martinghunt martinghunt merged commit e51db6a into Mykrobe-tools:master May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinghunt